如果你的calculateStr()方法返回null，然后你试图在str上调用一个方法，你有NullPointerException的风险。

更一般地说，避免使用空值变量。顺便说一下，它对类属性更强。

在while循环之外声明String str允许它在while循环内外被引用。在while循环中声明String str只允许它在while循环中被引用。

如果你不需要在while循环之后使用str(范围相关)，那么第二个条件，即。

  while(condition){
        String str = calculateStr();
        .....
    }

如果你只在条件为真时才在堆栈上定义一个对象，那就更好了。也就是说，如果你需要，就使用它

局部变量的作用域应该总是尽可能的小。

在你的例子中，我假设str没有在while循环之外使用，否则你就不会问这个问题，因为在while循环内部声明它不是一个选项，因为它不会编译。

因此，由于str不在循环之外使用，因此str的最小作用域是在while循环内。

因此，答案强调str绝对应该在while循环中声明。没有如果，没有并且，没有但是。

The only case where this rule might be violated is if for some reason it is of vital importance that every clock cycle must be squeezed out of the code, in which case you might want to consider instantiating something in an outer scope and reusing it instead of re-instantiating it on every iteration of an inner scope. However, this does not apply to your example, due to the immutability of strings in java: a new instance of str will always be created in the beginning of your loop and it will have to be thrown away at the end of it, so there is no possibility to optimize there.

编辑:(在答案下面注入我的评论)

In any case, the right way to do things is to write all your code properly, establish a performance requirement for your product, measure your final product against this requirement, and if it does not satisfy it, then go optimize things. And what usually ends up happening is that you find ways to provide some nice and formal algorithmic optimizations in just a couple of places which make our program meet its performance requirements instead of having to go all over your entire code base and tweak and hack things in order to squeeze clock cycles here and there.

正如很多人指出的那样，

String str;
while(condition){
    str = calculateStr();
    .....
}

没有比这更好的了:

while(condition){
    String str = calculateStr();
    .....
}

因此，如果你不重用变量，就不要在变量作用域之外声明变量。

根据谷歌Android开发指南，变量范围应该是有限的。请查看此链接:

极限变量范围